refactor(cli): merge argument parsing and command execution #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
force-pushed
the
ENG-834/merge-cli-and-command-structs
branch
from
f90d3e3
to
b640028
Compare
sambukowski
approved these changes
Sep 27, 2024
SuperFluffy
force-pushed
the
ENG-834/merge-cli-and-command-structs
branch
from
ec8acf2
to
5dfa949
Compare
sambukowski
reviewed
Sep 30, 2024
sambukowski
approved these changes
Sep 30, 2024
joroshiba
approved these changes
Oct 1, 2024
SuperFluffy
force-pushed
the
ENG-834/merge-cli-and-command-structs
branch
from
4f7b74d
to
174b5fc
Compare
steezeburger
added a commit
that referenced
this pull request
Oct 7, 2024
* main: (34 commits) feat(proto): add bundle and optimistic block apis (#1519) feat(sequencer)!: make empty transactions invalid (#1609) chore(sequencer): simplify boolean expressions in `transaction container` (#1595) refactor(cli): merge argument parsing and command execution (#1568) feat(charts): astrotrek chart (#1513) chore(charts): genesis template to support latest changes (#1594) fix(ci): code freeze action fix (#1610) chore(sequencer)!: exclusively use Borsh encoding for stored data (ENG-768) (#1492) ci: code freeze through github actions (#1588) refactor(sequencer): use builder pattern for transaction container tests (#1592) feat(conductor)!: implement chain ID checks (#1482) chore(ci): upgrade audit-check (#1577) feat(sequencer)!: transaction categories on UnsignedTransaction (#1512) fix(charts): sequencer prometheus rules (#1598) chore(all): Migrate all instances of `#[allow]` to `#[expect]` (#1561) chore(charts,sequencer-faucet): asset precision (#1517) chore(docs): endpoints (#1543) fix(docker): use target binary build param as name of image entrypoint (#1573) fix(ci): ibc bridge test timeout (#1587) Feature: Add `graph-node` to charts. (#1489) ...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
## Summary Removes unused code from astria cli. ## Background This code was no longer included in the module tree. It should have been removed in #1568 but forgotten. ## Changes - Remove unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the CLI to give it a cleaner structure.
Background
The CLI was split into a
climodule that was concerned with parsing arguments, and acommandswhich consumed the argument data structures.The patch clears this up by implementing inherent
<Args>::runmethods on all leaf argument types, so that the implementation follows the same structure for all its effects.Note that this match does restructure the public facing command line (except for a few lines of documentation). It merely restructures the implementation.
Changes
clap::Argsto have an inherent methodrun.Testing
These will be tested in follow PRs. Smoke tests using a subset of the astria CLI commands should still work.
Related Issues
Closes #1546